Merged
Conversation
…tions - Added automatic detection of services using ports 80/443 and enhanced user prompts for configuring external proxies (Nginx, Traefik). - Implemented options for auto-configuration based on detected proxies, allowing for easier setup in non-interactive mode. - Updated messaging to guide users through the selection process for handling HTTPS with their domain.
…script - Added logic to automatically detect the Traefik container and its associated networks. - Implemented user prompts for selecting a network when multiple non-bridge networks are found. - Improved fallback mechanisms for network detection and user interaction in non-interactive mode. - Updated Docker Compose configuration to dynamically set entrypoints and certresolver based on detected Traefik settings.
…d non-interactive modes - Added a section for interactive installation using curl, prompting users for configuration options. - Clarified the non-interactive installation process and provided example commands. - Removed outdated instructions for interactive mode that were previously included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
install.shscript to automatically detect and configure external proxies (nginx and Traefik) when ports 80/443 are already in use. It provides both auto-configuration and manual setup options, improves user guidance, and adds support for Traefik labels and Docker network integration. The script now offers a smoother installation experience for users deploying with existing proxies.Proxy detection and auto-configuration improvements:
PROXY_AUTO_CONFIGaccordingly. Users are prompted to choose auto-config, manual setup, or to free ports if nginx or Traefik is detected.Traefik support enhancements:
docker-compose.yml. Also detects entrypoint and certresolver from Traefik container args. [1] [2]User guidance and summary improvements:
General script improvements:
PROXY_AUTO_CONFIG,TRAEFIK_CONTAINER,TRAEFIK_NETWORK) and refactored control flow to support the new proxy detection and configuration logic. [1] [2]These changes make the installer more robust and user-friendly for deployments behind existing proxies.